✨ Call access_aws for all paths and cache
#762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koncopd
force-pushed
the
s3_creds
branch
2 times, most recently
from
389af04
to
7148bff
Compare
falexwolf
changed the title
access_aws for all paths and cache
Koncopd
commented
May 17, 2024
| @@ -235,6 +236,12 @@ def root(self) -> UPath: | |||
| if self._root is None: | |||
| # below makes network requests to get credentials | |||
| self._root = create_path(self._root_init, access_token=self.access_token) | |||
| elif getattr(self._root, "protocol", "") == "s3": | |||
| # this is needed to be sure that the root always have nonexpired credentials | |||
There was a problem hiding this comment.
So, this cannot yet be merged? 🤔
There was a problem hiding this comment.
Great, in that case I'll merge and start playing with it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.