♻️ Better dialogue working with outdated instance settings and remove… #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… backward compat for no IDs
|
fails due to https://github.com/laminlabs/laminhub/issues/1036 and other things (solved here ). |
falexwolf
commented
Aug 12, 2024
| ) from error | ||
| if settings_store.id == "null": |
There was a problem hiding this comment.
This is no longer needed. It dates back to when we didn't have insance uuids.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
==========================================
+ Coverage 82.66% 82.68% +0.02%
==========================================
Files 42 42
Lines 3230 3228 -2
==========================================
- Hits 2670 2669 -1
+ Misses 560 559 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… backward compat for no IDs