New: ignore db ordering in dbResponse feature #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ikramanop, может ещё тесты добавить? |
|
Да, тесты можно в таком формате response_header_test.go |
Добавил простенькие тесты. |
Cdayz
reviewed
May 12, 2022
| @@ -72,35 +77,97 @@ func (c *ResponseDbChecker) Check(t models.TestInterface, result *models.Result) | |||
| return errors, nil | |||
| } | |||
|
|
|||
| func compareDbResp(t models.TestInterface, result *models.Result) ([]error, error) { | |||
| func compareDbRespWithoutOrdering(expected, actual []string, testName string) ([]error, error) { | |||
There was a problem hiding this comment.
мне кажется, что можно сделать проще и читабельнее в разы, просто отредактировав исходную функцию проверки
import (
...
"sort"
...
)
...
func compareDbResp(expected, actual []string, testName string, query interface{}, reorder bool) ([]error, error) {
var errors []error
var actualJson interface{}
var expectedJson interface{}
if reorder {
sort.Strings(expected)
sort.Strings(actual)
}
...
ikramanop
force-pushed
the
feature/ignore-db-ordering
branch
from
bf0b76c
to
7433636
Compare
…e/ignore-db-ordering
Cdayz
approved these changes
May 17, 2022
vitkarpenko
approved these changes
May 18, 2022
maximdanilchenko
approved these changes
May 18, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлен новый тип comparisonParams - ignoreDbOrdering, который может использоваться для проверки результата dbQuery не по порядку