Speed up on go1.15 v2 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
luza
suggested changes
Sep 3, 2020
mocks/service_mock.go
Outdated
| @@ -38,10 +38,16 @@ func (m *ServiceMock) StartServer() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Not used: backward compatibility with public interface | |||
| func (m *ServiceMock) ShutdownServer() { | |||
There was a problem hiding this comment.
This is not a library-wide public method, so feel free to change its signature. Simply expand it with Context argument.
mocks/mocks.go
Outdated
| func (m *Mocks) Shutdown() { | ||
| _ = m.ShutdownContext(context.TODO()) |
There was a problem hiding this comment.
I guess here we should pre-cancel the context to defeat the slowing down issue.
There was a problem hiding this comment.
I planned to switch my tests to context-related method, and do it in my code, but ok, lets leave "old" behaviour here.
mocks/service_mock.go
Outdated
| _ = m.ShutdownServerContext(context.TODO()) | ||
| } | ||
|
|
||
| func (m *ServiceMock) ShutdownServerContext(ctx context.Context) (err error) { |
There was a problem hiding this comment.
Let's use unnamed return value, just like in all other methods around. Just to keep the coding style unified.
luza
approved these changes
Sep 3, 2020
fetinin
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as #58, but with different methods to shutdown, which accepts context from outside