Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework reflect Symbol fields API #10705

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Rework reflect Symbol fields API #10705

merged 1 commit into from
Dec 9, 2020

Conversation

nicolasstucki
Copy link
Contributor

Follow the same design as methods and types

@nicolasstucki nicolasstucki added this to the 3.0.0-M3 milestone Dec 8, 2020
@nicolasstucki nicolasstucki force-pushed the rework-reflect-Symbol-fields-API branch 2 times, most recently from 2e2669d to e9ac710 Compare December 9, 2020 09:38
@nicolasstucki
Rework reflect Symbol fields API
74c69a5 
Follow the same design as methods and types
@nicolasstucki nicolasstucki force-pushed the rework-reflect-Symbol-fields-API branch from e9ac710 to 74c69a5 Compare December 9, 2020 10:53
@nicolasstucki nicolasstucki self-assigned this Dec 9, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review December 9, 2020 12:48
@nicolasstucki nicolasstucki added the release-notes Should be mentioned in the release notes label Dec 9, 2020
liufengyun
liufengyun approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit d0db6d5 into scala:master Dec 9, 2020
@nicolasstucki nicolasstucki deleted the rework-reflect-Symbol-fields-API branch December 9, 2020 13:08
@Kordyjan Kordyjan modified the milestones: 3.0.0-M3, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
release-notes Should be mentioned in the release notes
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @liufengyun @Kordyjan