-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add idempotency check on bootstrapped dotty #2756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
idempotency-on-boot
branch
from
June 15, 2017 08:13
68fe0e1
to
c50936a
Compare
nicolasstucki
force-pushed
the
idempotency-on-boot
branch
from
June 18, 2017 15:50
9a5a46c
to
b1487a2
Compare
felixmulder
approved these changes
Jun 19, 2017
tests/idempotency/Checker.scala
Outdated
@@ -0,0 +1,10 @@ | |||
|
|||
import java.nio.file.{Files, Path, Paths} | |||
import java.util.stream.{ Stream => JStream } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why spaces in the bottom one and no spaces in the top one? :)
@@ -0,0 +1,8 @@ | |||
import java.nio.file.{Files, Path, Paths} | |||
import java.util.stream.{ Stream => JStream } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment below
nicolasstucki
force-pushed
the
idempotency-on-boot
branch
from
June 19, 2017 09:47
5b1d7f2
to
711e6f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.