Rewrite typer.TermRefSet
#5593
Merged
Rewrite typer.TermRefSet
#5593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
allanrenucci
force-pushed
the
rewrite-termrefset
branch
from
42e5a8f
to
91dfe82
Compare
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/5593/ to see the changes. Benchmarks is based on merging with master (8004566) |
odersky
approved these changes
Dec 11, 2018
Rewrite motivated by 2.13 collection rewrite. `TermRefSet` used to extends `mutable.Traversable[TermRef]` which is now deprecated. If we want to keep with the spirit of the previous API, the right thing would be to replace `Traversable` with `Iterable`. But then we'd have to implement an iterator, which might be less efficient.
allanrenucci
force-pushed
the
rewrite-termrefset
branch
from
91dfe82
to
58b0eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite motivated by 2.13 collection rewrite.
TermRefSetused to extendsmutable.Traversable[TermRef]which is now deprecated.