Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5526: Better type inference for dependent function types #5631

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Fix #5526: Better type inference for dependent function types #5631

merged 2 commits into from
Dec 17, 2018

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 17, 2018

No description provided.

@odersky
Copy link
Contributor Author

odersky commented Dec 17, 2018

This is essentially a slightly improved version of #5528 by @b-studios , with two changes

  • better error message than UnspecifiedError in case something fails
  • fixed pickling problem

The pickling problem was quite trivial: A position for a symbol was missing, which caused test pickling under -Yprint-pos-syms to fail.

Everything else seems to work nicely. Thanks @b-studios for having done all the hard work!

@odersky odersky requested a review from smarter December 17, 2018 12:55
@odersky odersky mentioned this pull request Dec 17, 2018
Closed
@b-studios
Copy link
Contributor

Thanks @odersky for looking into it!

@odersky odersky added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label Dec 17, 2018
@odersky odersky merged commit 40e68d9 into scala:master Dec 17, 2018
@odersky
Copy link
Contributor Author

odersky commented Dec 17, 2018 •
edited
Loading

Oops that was too fast. I meant to merge another PR, not this one. @smarter, if you have concerns we need to put them in a separate PR.

@allanrenucci allanrenucci deleted the fix-#5526 branch December 17, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter Awaiting requested review from smarter

Assignees

@smarter smarter

Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @b-studios @smarter