Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VHDL] Fix VHDL implementation of bitwidth modifiers #18

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

lucas-rami
Copy link
Collaborator

This commit replaces the Handshaking logic in the VHDL implementation of the bitwidth modifier entities trunc_op, sext_op, and zext_op. Previously, the ready signal was computed as a combination of the pValidArray (valid predecessor signal) and the nReadyArray (ready successor signal). While this works in most cases, it is too conservative and may cause deadlocks/critical path increases. As such, the ready signal is modified to just "forward" the dataflow successor's one. This makes the bitwidth modification components act as perfect "forwarders" of control signals, only altering the data signal in the process.

@lucas-rami lucas-rami merged commit 98d105e into master Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant