Skip to content
This repository has been archived by the owner on Aug 15, 2023. It is now read-only.

Packaging #3

Merged
8 commits merged into from
Oct 15, 2019
Merged

Packaging #3

8 commits merged into from
Oct 15, 2019

Conversation

kevinyang372
Copy link
Contributor

Updates:

  • Rewrote the README.md
  • Added setup.py
  • Added LICENSE

Right now you could check the project on https://pypi.org/project/pylana/

Or install with

$ pip3 install pylana

@kevinyang372 kevinyang372 requested a review from a user October 15, 2019 14:10
setup.py Outdated
long_description_content_type='text/markdown',
url='https://github.com/lanalabs/pylana',
author='Yunfan Yang',
author_email='yunfan.yang@minerva.kgi.edu',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to use a company email here (contact@lanalabs.com), in case anything comes up after your internship.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only left a minor comment on the email address referenced in the setup, otherwise this is LGTM. Thanks for adding this so quickly!

@ghost ghost merged commit 4cc4d7b into master Oct 15, 2019
@bosyk bosyk deleted the packaging branch October 8, 2020 10:53
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant