Rewrite MicroBitImage parsing code so it doesn't depend on atoi() #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the function atoi() pulls in a dependency from newlib, which in turn pulls in locale support, and locale support requires about 350 bytes of RAM. This patch removes such a dependency by rewriting the MicroBitImage parsing code so that it directly converts the input string to an integer instead of building a buffer and passing it to atoi(). This patch saves about 640 bytes of code space and 364 bytes of RAM. It also reduces the amount of stack space used by the MicroBitImage constructor.
|
I tested this with the simple-animation code in microbit-samples. It seems to work. |
|
Thanks @dpgeorge - looks good, thanks for the contribution. |
|
Thanks @finneyj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the function atoi() pulls in a dependency from newlib, which in turn
pulls in locale support, and locale support requires about 350 bytes of
RAM. This patch removes such a dependency by rewriting the MicroBitImage
parsing code so that it directly converts the input string to an integer
instead of building a buffer and passing it to atoi().
This patch saves about 640 bytes of code space and 364 bytes of RAM. It
also reduces the amount of stack space used by the MicroBitImage
constructor.
See #323 for further discussion.