Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opening non-existent dataset should return Error::NotFound instead of Error::IO #2067

Open
chebbyChefNEQ opened this issue Mar 13, 2024 · 0 comments
Open

opening non-existent dataset should return Error::NotFound instead of Error::IO #2067

chebbyChefNEQ opened this issue Mar 13, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rust Rust related tasks

Comments

@chebbyChefNEQ
Copy link
Contributor

we have a blanket conversion of object_store::Error -> Error::IO.
@chebbyChefNEQ chebbyChefNEQ added enhancement New feature or request rust Rust related tasks labels Mar 13, 2024
@chebbyChefNEQ chebbyChefNEQ changed the title Trying to open non-existent dataset should return Error::NotFound instead of Error::IO opening non-existent dataset should return Error::NotFound instead of Error::IO Mar 13, 2024
@chebbyChefNEQ chebbyChefNEQ changed the title opening non-existent dataset should return Error::NotFound instead of Error::IO opening non-existent dataset should return Error::NotFound instead of Error::IO Mar 13, 2024
@chebbyChefNEQ chebbyChefNEQ added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 15, 2024
@broccoliSpicy broccoliSpicy mentioned this issue May 9, 2024
Closed
broccoliSpicy added a commit to broccoliSpicy/lance that referenced this issue May 9, 2024
@broccoliSpicy
Add more granular conversion from object_store::Error to Error
36ee684 
Fixes lancedb#2067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rust Rust related tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chebbyChefNEQ