Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates and refactor #683

Merged
merged 83 commits into from
Jan 18, 2024
Merged

docs: Updates and refactor #683

merged 83 commits into from
Jan 18, 2024

Conversation

prrao87
Copy link
Contributor

@prrao87 prrao87 commented Dec 4, 2023

This PR makes incremental changes to the documentation.

Chores

  • Add dark mode
  • Fix headers in navbar
  • Add extra.css to customize navbar styles
  • Customize fonts for prose/code blocks, navbar and admonitions
  • Inspect all admonition boxes (remove redundant dropdowns) and improve clarity and readability
  • Ensure that all images in the docs have white background (not transparent) to be viewable in dark mode
  • Improve code formatting in code blocks to make them consistent with autoformatters (eslint/ruff)
  • Add bolder weight to h1 headers
  • Add diagram showing the difference between embedded (OSS) and serverless (Cloud)
  • Fix Creating an empty table section: right now, the subheaders are not clickable.
  • In critical data ingestion methods like table.add (among others), the type signature often does not match the actual code
  • Proof-read each documentation section and rewrite as necessary to provide more context, use cases, and explanations so it reads less like reference documentation. This is especially important for CRUD and search sections since those are so central to the user experience.

Restructure/new content

@prrao87 prrao87 changed the title Update docs build steps Update docs 🚧 WIP Dec 6, 2023
@prrao87 prrao87 removed the request for review from AyushExel December 6, 2023 00:13
@prrao87 prrao87 changed the title Update docs 🚧 WIP docs: 🚧 Updates and refactor Dec 6, 2023
@prrao87
Copy link
Contributor Author

prrao87 commented Jan 15, 2024

The docs from this branch are ready for review. I've left out the benchmarks and the Rust docs in the tasks, but I think most of the other things we discussed are in there.

My thinking is that once you think it's ready, we get this merged in main @changhiskhan and @AyushExel, so that we can take stock of what can be fixed once we see it live (we can always make smaller PRs to fix any outstanding issues).

@AyushExel
Copy link
Contributor

Agree. I think we should merge this to main. Smaller improvements can come later on a case by case basis

@prrao87
Copy link
Contributor Author

prrao87 commented Jan 15, 2024

Awesome! I was trying to fix the broken bits for CI, let's see how this goes, fix them and merge when finished 🙏🏽

@AyushExel do you know how to address that circular imports issue for polars? it's from the recent PR from Chang, but he seems to not have that issue on main.

@AyushExel
Copy link
Contributor

Awesome! I was trying to fix the broken bits for CI, let's see how this goes, fix them and merge when finished 🙏🏽

@AyushExel do you know how to address that circular imports issue for polars? it's from the recent PR from Chang, but he seems to not have that issue on main.

Yeah the circular import issue seems weird not happening even in the branch.. just occurs during docs test

@AyushExel
Copy link
Contributor

hmm..failing even after excluding the polars tests..Can investigate tomorrow

docs/src/basic.md Outdated Show resolved Hide resolved
docs/src/cloud/index.md Outdated Show resolved Hide resolved

## Architecture

LanceDB Cloud provides the same underlying fast vector store that powers the OSS version, but without the need to maintain your own infrastructure. Because it's serverless, you only pay for the storage you use, and you can scale compute up and down as needed depending on the size of your data and its associated index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can scale compute up and down as needed depending on the size of your data and its associated index

This doesn't seem quite right. IIUC users don't set the scale; we automatically scale for optimal performance. Right @QianZhu ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Users don't set the scale. The elastic scale is taken care by us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you frame it using that snippet @QianZhu ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

Because it's serverless, you only pay for the storage you use, and we take care of scaling compute up and down as needed depending on the size of your data and its associated index.

docs/src/concepts/data_management.md Outdated Show resolved Hide resolved
docs/src/concepts/data_management.md Outdated Show resolved Hide resolved
docs/src/concepts/index_ivfpq.md Outdated Show resolved Hide resolved
docs/src/concepts/index_ivfpq.md Outdated Show resolved Hide resolved
docs/src/concepts/index_ivfpq.md Outdated Show resolved Hide resolved
docs/src/concepts/index_ivfpq.md Outdated Show resolved Hide resolved
docs/src/concepts/index_ivfpq.md Show resolved Hide resolved
prrao87 and others added 2 commits January 15, 2024 20:34
Co-authored-by: Will Jones <willjones127@gmail.com>
Copy link
Contributor Author

@prrao87 prrao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will clean up the other suggestion too, thanks, Will!

@prrao87
Copy link
Contributor Author

prrao87 commented Jan 16, 2024

@AyushExel, Python CI issues fixed. there's another issue with the node CI - I can't find anything wrong in the code that might be the source of the issue. Can you check when you have a moment?

@AyushExel AyushExel merged commit 119b928 into main Jan 18, 2024
13 checks passed
@AyushExel AyushExel deleted the prashanth/docs-update branch January 18, 2024 18:48
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this pull request Apr 5, 2024
This PR makes incremental changes to the documentation.

* Closes lancedb#697 
* Closes lancedb#698

## Chores
- [x] Add dark mode
- [x] Fix headers in navbar
- [x] Add `extra.css` to customize navbar styles
- [x] Customize fonts for prose/code blocks, navbar and admonitions
- [x] Inspect all admonition boxes (remove redundant dropdowns) and
improve clarity and readability
- [x] Ensure that all images in the docs have white background (not
transparent) to be viewable in dark mode
- [x] Improve code formatting in code blocks to make them consistent
with autoformatters (eslint/ruff)
- [x] Add bolder weight to h1 headers
- [x] Add diagram showing the difference between embedded (OSS) and
serverless (Cloud)
- [x] Fix [Creating an empty
table](https://lancedb.github.io/lancedb/guides/tables/#creating-empty-table)
section: right now, the subheaders are not clickable.
- [x] In critical data ingestion methods like `table.add` (among
others), the type signature often does not match the actual code
- [x] Proof-read each documentation section and rewrite as necessary to
provide more context, use cases, and explanations so it reads less like
reference documentation. This is especially important for CRUD and
search sections since those are so central to the user experience.

## Restructure/new content 
- [x] The section for [Adding
data](https://lancedb.github.io/lancedb/guides/tables/#adding-to-a-table)
only shows examples for pandas and iterables. We should include pydantic
models, arrow tables, etc.
- [x] Add conceptual tutorial for IVF-PQ index
- [x] Clearly separate vector search, FTS and filtering sections so that
these are easier to find
- [x] Add docs on refine factor to explain its importance for recall.
Closes lancedb#716
- [x] Add an FAQ page showing answers to commonly asked questions about
LanceDB. Closes lancedb#746
- [x] Add simple polars example to the integrations section. Closes lancedb#756
and closes lancedb#153
- [ ] Add basic docs for the Rust API (more detailed API docs can come
later). Closes lancedb#781
- [x] Add a section on the various storage options on local vs. cloud
(S3, EBS, EFS, local disk, etc.) and the tradeoffs involved. Closes lancedb#782
- [x] Revamp filtering docs: add pre-filtering examples and redo headers
and update content for SQL filters. Closes lancedb#783 and closes lancedb#784.
- [x] Add docs for data management: compaction, cleaning up old versions
and incremental indexing. Closes lancedb#785
- [ ] Add a benchmark section that also discusses some best practices.
Closes lancedb#787

---------

Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
westonpace pushed a commit that referenced this pull request Apr 5, 2024
This PR makes incremental changes to the documentation.

* Closes #697
* Closes #698

- [x] Add dark mode
- [x] Fix headers in navbar
- [x] Add `extra.css` to customize navbar styles
- [x] Customize fonts for prose/code blocks, navbar and admonitions
- [x] Inspect all admonition boxes (remove redundant dropdowns) and
improve clarity and readability
- [x] Ensure that all images in the docs have white background (not
transparent) to be viewable in dark mode
- [x] Improve code formatting in code blocks to make them consistent
with autoformatters (eslint/ruff)
- [x] Add bolder weight to h1 headers
- [x] Add diagram showing the difference between embedded (OSS) and
serverless (Cloud)
- [x] Fix [Creating an empty
table](https://lancedb.github.io/lancedb/guides/tables/#creating-empty-table)
section: right now, the subheaders are not clickable.
- [x] In critical data ingestion methods like `table.add` (among
others), the type signature often does not match the actual code
- [x] Proof-read each documentation section and rewrite as necessary to
provide more context, use cases, and explanations so it reads less like
reference documentation. This is especially important for CRUD and
search sections since those are so central to the user experience.

- [x] The section for [Adding
data](https://lancedb.github.io/lancedb/guides/tables/#adding-to-a-table)
only shows examples for pandas and iterables. We should include pydantic
models, arrow tables, etc.
- [x] Add conceptual tutorial for IVF-PQ index
- [x] Clearly separate vector search, FTS and filtering sections so that
these are easier to find
- [x] Add docs on refine factor to explain its importance for recall.
Closes #716
- [x] Add an FAQ page showing answers to commonly asked questions about
LanceDB. Closes #746
- [x] Add simple polars example to the integrations section. Closes #756
and closes #153
- [ ] Add basic docs for the Rust API (more detailed API docs can come
later). Closes #781
- [x] Add a section on the various storage options on local vs. cloud
(S3, EBS, EFS, local disk, etc.) and the tradeoffs involved. Closes #782
- [x] Revamp filtering docs: add pre-filtering examples and redo headers
and update content for SQL filters. Closes #783 and closes #784.
- [x] Add docs for data management: compaction, cleaning up old versions
and incremental indexing. Closes #785
- [ ] Add a benchmark section that also discusses some best practices.
Closes #787

---------

Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants