Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump lance to 0.9.7 #826

Merged
merged 4 commits into from
Jan 19, 2024
Merged

bump lance to 0.9.7 #826

merged 4 commits into from
Jan 19, 2024

Conversation

albertlockett
Copy link
Contributor

No description provided.

Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump python as well

@albertlockett
Copy link
Contributor Author

fixing some compiler errors.. moving to draft while fixing

@albertlockett albertlockett marked this pull request as draft January 19, 2024 00:24
@changhiskhan
Copy link
Contributor

please bump python too while you're at it

@albertlockett albertlockett marked this pull request as ready for review January 19, 2024 01:17
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there node and python tests for the index stats APIs? just want to make sure we're not breaking anything there

@albertlockett
Copy link
Contributor Author

are there node and python tests for the index stats APIs? just want to make sure we're not breaking anything there

Looks like we only have coverage on the node apis. I don't think we ever exposed it through the python api.

it('should be able to list index and stats', async function () {
const uri = await createTestDB(32, 300)
const con = await lancedb.connect(uri)
const table = await con.openTable('vectors')
await table.createIndex({ type: 'ivf_pq', column: 'vector', num_partitions: 2, max_iters: 2, num_sub_vectors: 2 })
const indices = await table.listIndices()
expect(indices).to.have.lengthOf(1)
expect(indices[0].name).to.equal('vector_idx')
expect(indices[0].uuid).to.not.be.equal(undefined)
expect(indices[0].columns).to.have.lengthOf(1)
expect(indices[0].columns[0]).to.equal('vector')
const stats = await table.indexStats(indices[0].uuid)
expect(stats.numIndexedRows).to.equal(300)
expect(stats.numUnindexedRows).to.equal(0)
}).timeout(50_000)

@changhiskhan changhiskhan merged commit 7af2138 into main Jan 19, 2024
16 checks passed
@changhiskhan changhiskhan deleted the bump-lance-0.9.7 branch January 19, 2024 04:44
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this pull request Apr 5, 2024
westonpace pushed a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants