Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be useful to have periodic boundary conditions working #1893

Open
gregtucker opened this issue Feb 14, 2024 · 0 comments
Open

Would be useful to have periodic boundary conditions working #1893

gregtucker opened this issue Feb 14, 2024 · 0 comments

Comments

@gregtucker
Copy link
Contributor

It would be great to be able to handle periodic ("wrap-around") boundary conditions. There is an ancient and currently non-functional version of this in the set_looped_boundary_condition function and the corresponding "looped" node BC type. This node-BC type is not recognized by the set_status_at_link functionality, with the result that any attempt to access status_at_link after invoking set_looped_boundary_conditions causes an assertion failure.

This is probably an easy fix - maybe just a matter of adding the looped BC code to the function that identifies active links - but there may be some subtleties, and any fix will need some thoughtful test cases to go with it, to make sure it works both with continuum problems and flow routing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant