Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash handler does not respect --yes #242

Closed
AaronFeledy opened this issue Feb 24, 2024 · 3 comments · Fixed by #247
Closed

Crash handler does not respect --yes #242

AaronFeledy opened this issue Feb 24, 2024 · 3 comments · Fixed by #247
Assignees

Comments

@AaronFeledy
Copy link
Member

If an error occurs during lando setup -y the user is shown a CRASH message followed by a prompt asking if they'd like to send an error report. When running this as part of a scripted process, it may not be desirable, or even possible for the user to respond, potentially leading to a hung process. The error handler should respect the -y and it should not prompt the user.

@AaronFeledy
Copy link
Member Author

Or if privacy might be a concern here, lando setup could disable the error reporting during non-interactive execution if the user has not yet had the opportunity to respond to this prompt.

@pirog pirog self-assigned this Feb 29, 2024
@pirog
Copy link
Member

pirog commented Feb 29, 2024

@AaronFeledy in the setup-lando GitHub Action we manually write the needed file to do this.
https://github.com/lando/setup-lando/blob/main/setup-lando.js#L154-L159

That said, i think this is a good addition and think it should more or less work like this:

  1. honor the -y flag as you indicate
  2. if the command is run non-interactively without -y then assume a "no" value for the crash report question so that it doesnt block

pirog added a commit that referenced this issue Feb 29, 2024
@pirog pirog linked a pull request Feb 29, 2024 that will close this issue
pirog added a commit that referenced this issue Feb 29, 2024
@pirog
Copy link
Member

pirog commented Feb 29, 2024

@AaronFeledy got a PR for this #247, let me know what you think

pirog added a commit that referenced this issue Feb 29, 2024
pirog added a commit that referenced this issue Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants