lando/mysql#53: Address db-import error by quoting database name. Add tests. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lando-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Wanted to add some tests here that "cover" the case described in lando/mysql#53, but perhaps that's overkill/misguided. Definitely should add some tests to the recipes to check functionality of db import/export with a second DB service being added. |
pirog
pushed a commit
that referenced
this pull request
Oct 10, 2024
… tests. (#173) * lando/mysql#53: Address db-import error by quoting database name. Add tests. * lando/mysql#53: Update the tests with correct hostnames/envvars. * lando/mysql#53: Fix core test issue. Remove debugging code. * Update changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lando/mysql#53.
See comments in lando/mysql#53 (comment) and lando/mysql#53 (comment)