Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run user hooks regardless of buildScript status. #186

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

reynoldsalec
Copy link
Member

@reynoldsalec reynoldsalec commented Aug 1, 2024

this.buildScript reflects what's in the Landofile, but if you use addHookFile() in a builder to add a user hook, it won't be reflected in this.buildScript. Lando should execute await this.runHook(['app', 'user']); regardless of this.buildScript.

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for lando-core ready!

Name Link
🔨 Latest commit cebdc82
🔍 Latest deploy log https://app.netlify.com/sites/lando-core/deploys/66abc86ab9ca7a0008386ec0
😎 Deploy Preview https://deploy-preview-186--lando-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pirog pirog merged commit 4bd471e into main Aug 1, 2024
54 of 55 checks passed
@pirog pirog deleted the app-user-build branch August 1, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants