#59: Create fork of electron-deeplink that works for MacOS and unifie… #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s our deeplink handling across OS's.
|
...and of course I'll fix the linting 🤦 |
…dating electron-builder for M1 Macs.
* Start of TS undo * Adjust deeplinks.js * More typescript removal and other clean up * Adjust linter * Update node version
labboy0276
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the key here is basically removing the #setAppProtocol functionality...this only runs for MacOS on Dev and seems to setup the plist entry that MacOS no longer needs due to Electron's native handling. See https://github.com/glawson/electron-deeplink/blob/master/src/index.ts#L110 for reference on that function.
Going to pass this by @pirog (and @labboy0276 probably good to make sure I didn't fubar something for Linux).