Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 10.1 lazy aggregation #48

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

neclimdul
Copy link
Contributor

This adds support for Drupal's updated CSS and JavaScript aggregation .

This adds support for Drupal's updated CSS and JavaScript aggregation

 - https://www.drupal.org/node/1014086
 - https://www.drupal.org/node/2888767#nginx-php-fpm
@netlify
Copy link

netlify bot commented Feb 3, 2023

👷 Deploy request for lando-drupal accepted.

Name Link
🔨 Latest commit 0da201a
🔍 Latest deploy log https://app.netlify.com/sites/lando-drupal/deploys/63dd2c6dae13730009d503a9

@neclimdul
Copy link
Contributor Author

This is pretty easy to test. checkout the latest 10.1.x branch of Drupal core, add a basic D10 lando setup, install the site.

As soon as the site is finished installing you'll be greeted with a site that has not styles. inspecting the network tab you'll see 404's for all the css/js requests to the aggregated urls.

Notes:

  1. This is the exact change from the change log but there was some discussion in the Drupal slack if it made sense for development systems like ddev and lando to just have the sites/*/files/ fallback on core to support any other modules that have lazy handlers. 🤷
  2. It might make sense to backport this to D9 recipe in case people like me are jumping back and forth between d10 and d9 and have the d9 recipe in their lando config while working on migration/updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants