Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ESlint/Prettier on the project #114

Closed
mandaputtra opened this issue Jan 28, 2022 · 2 comments
Closed

Integrate ESlint/Prettier on the project #114

mandaputtra opened this issue Jan 28, 2022 · 2 comments

Comments

@mandaputtra
Copy link
Contributor

There are many linting problems (unused variable, etc.) that I encounter on the codebase. I think adding ESLint (and or Prettier) for linter and formatting code would helpful. It also catches a silly issue like these #111.

I'm thinking of this strategy.

  • Add ESLint/Prettier
  • Make commit hooks using husky so whenever we commit a code it will lint and fix it first
  • Use standard code style (just my opinion)

Just let me know if this would be helpful for the project, I'll be working on it.

@lane711
Copy link
Owner

lane711 commented Jan 28, 2022

Hi @mandaputtra I 100% agree and would happily accept any PRs adding ESLint or both of them. I'm good with the standard code style. Husky automation would also be great. Thank you!

@lane711
Copy link
Owner

lane711 commented Jan 28, 2022

BTW - after doing any refactor or reformatting you can run the e2e cypress tests using npm test to smoke test the entire framework.

@lane711 lane711 closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants