Fix for recent breaking changes #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ConversationalRetrievalChain instead of ChatVectorDBChain; Update AsyncCallbackManager after refactor
Link to ConversationRetrievalChain example docs
Better link
|
@gadkins just tried your fix. I think you also need the change from this branch of yours: if I include that change on top of this branch it seems to work, thanks for figuring it out! |
|
It would be good to have this PR merged due to the package upgrade. Thanks! @hwchase17 |
mmmaia
reviewed
May 25, 2023
| qa = ChatVectorDBChain( | ||
| vectorstore=vectorstore, | ||
| qa = ConversationalRetrievalChain( | ||
| vectorstore=vectorstore.as_retriever(), |
There was a problem hiding this comment.
Also needs to update to the parameter from vectorstore to retriever:
qa = ConversationalRetrievalChain(
retriever=vectorstore.as_retriever(),
combine_docs_chain=doc_chain,
question_generator=question_generator,
callback_manager=manager,
return_source_documents=True,
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two breaking changes recently introduced in
hwchase17/langchain:ConversationalRetrievalChainreplacingChatVectorDBChainper this blogAsyncCallbackManagermoved tolangchain.callbacks.managerafter this refactor