Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transalor #75

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Add transalor #75

merged 3 commits into from
Jun 21, 2024

Conversation

pprados
Copy link
Contributor

@pprados pprados commented Jun 20, 2024

The SelfQuery PGVectorTranslator is not correct. The operator is "eq" and not "$eq".
This patch implements a new version of PGVectorTranslator.

It's necessary to release a new version before accepting another PR in langchain core.

@pprados pprados marked this pull request as ready for review June 20, 2024 11:42
@eyurtsev eyurtsev merged commit 533e965 into langchain-ai:main Jun 21, 2024
6 checks passed
@pprados pprados deleted the pprados/fix_translator branch June 21, 2024 13:52
eyurtsev pushed a commit to langchain-ai/langchain that referenced this pull request Jun 21, 2024
The SelfQuery PGVectorTranslator is not correct. The operator is "eq"
and not "$eq".
This patch use a new version of PGVectorTranslator from
langchain_postgres.

It's necessary to release a new version of langchain_postgres (see
[here](langchain-ai/langchain-postgres#75)
before accepting this PR in langchain.
lalanikarim pushed a commit to lalanikarim/langchain that referenced this pull request Jun 23, 2024
…ain-ai#23217)

The SelfQuery PGVectorTranslator is not correct. The operator is "eq"
and not "$eq".
This patch use a new version of PGVectorTranslator from
langchain_postgres.

It's necessary to release a new version of langchain_postgres (see
[here](langchain-ai/langchain-postgres#75)
before accepting this PR in langchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants