-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in code documentation to core Runnable methods #18804
Labels
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
good first issue
Good for newcomers
help wanted
Good issue for contributors
Ɑ: lcel
Related to LangChain Expression Language (LCEL)
Ɑ: Runnables
Related to Runnables
Comments
eyurtsev
added
documentation
Improvements or additions to documentation
help wanted
Good issue for contributors
good first issue
Good for newcomers
Ɑ: lcel
Related to LangChain Expression Language (LCEL)
labels
Mar 8, 2024
dosubot
bot
added
Ɑ: Runnables
Related to Runnables
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
labels
Mar 8, 2024
@eyurtsev Hi ,assign to me, thanks~ |
Claim a method :) Ideally the or only documents one method -- it's much faster to review and merge |
|
|
/assign - |
ccurme
added a commit
that referenced
this issue
Mar 19, 2024
…thod (docs only) (#19192) - **Description:** Add in code documentation to core Runnable with_retry method (docs only) - **Issue:** #18804 @baskaryan @eyurtsev PTAL --------- Co-authored-by: ccurme <chester.curme@gmail.com>
baskaryan
added a commit
that referenced
this issue
Mar 25, 2024
baskaryan
pushed a commit
that referenced
this issue
Mar 26, 2024
…ly) (#19517) - **Issue:** #18804 - @baskaryan, @eyurtsev
rahul-trip
pushed a commit
to daxa-ai/langchain
that referenced
this issue
Mar 27, 2024
… (docs only) (langchain-ai#18951) **PR message**: ***Delete this entire checklist*** and replace with - **Description:** [a description of the change](docs: Add in code documentation to core Runnable assign method) - **Issue:** the issue langchain-ai#18804
rahul-trip
pushed a commit
to daxa-ai/langchain
that referenced
this issue
Mar 27, 2024
…d (docs only) (langchain-ai#19104) - Description: [a description of the change] Add in code documentation to core Runnable with_fallbacks method (docs only) - Issue: the issue langchain-ai#18804 @eyurtsev PTAL
rahul-trip
pushed a commit
to daxa-ai/langchain
that referenced
this issue
Mar 27, 2024
…thod (docs only) (langchain-ai#19192) - **Description:** Add in code documentation to core Runnable with_retry method (docs only) - **Issue:** langchain-ai#18804 @baskaryan @eyurtsev PTAL --------- Co-authored-by: ccurme <chester.curme@gmail.com>
rahul-trip
pushed a commit
to daxa-ai/langchain
that referenced
this issue
Mar 27, 2024
…hain-ai#19395) - **Issue:** langchain-ai#18804 - @eyurtsev @ccurme PTAL --------- Co-authored-by: Bagatur <baskaryan@gmail.com> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
rahul-trip
pushed a commit
to daxa-ai/langchain
that referenced
this issue
Mar 27, 2024
langchain-ai#19515) **Description:** Docstring for method with_listerners() of class Runnable **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None
bechbd
pushed a commit
to bechbd/langchain
that referenced
this issue
Mar 29, 2024
…figurable_fields (langchain-ai#19722) **Description:** Update to the docstring for class RunnableSerializable, method configurable_fields **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this issue
Mar 30, 2024
… (docs only) (langchain-ai#18951) **PR message**: ***Delete this entire checklist*** and replace with - **Description:** [a description of the change](docs: Add in code documentation to core Runnable assign method) - **Issue:** the issue langchain-ai#18804
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this issue
Mar 30, 2024
…d (docs only) (langchain-ai#19104) - Description: [a description of the change] Add in code documentation to core Runnable with_fallbacks method (docs only) - Issue: the issue langchain-ai#18804 @eyurtsev PTAL
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this issue
Mar 30, 2024
…thod (docs only) (langchain-ai#19192) - **Description:** Add in code documentation to core Runnable with_retry method (docs only) - **Issue:** langchain-ai#18804 @baskaryan @eyurtsev PTAL --------- Co-authored-by: ccurme <chester.curme@gmail.com>
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this issue
Mar 30, 2024
…hain-ai#19395) - **Issue:** langchain-ai#18804 - @eyurtsev @ccurme PTAL --------- Co-authored-by: Bagatur <baskaryan@gmail.com> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this issue
Mar 30, 2024
langchain-ai#19515) **Description:** Docstring for method with_listerners() of class Runnable **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this issue
Mar 30, 2024
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this issue
Mar 30, 2024
…igurable_alternatives (langchain-ai#19724) **Description:** Update to the docstring for class RunnableSerializable, method configurable_alternatives **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this issue
Mar 30, 2024
…figurable_fields (langchain-ai#19722) **Description:** Update to the docstring for class RunnableSerializable, method configurable_fields **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this issue
Mar 30, 2024
…thod (docs only) (langchain-ai#19192) - **Description:** Add in code documentation to core Runnable with_retry method (docs only) - **Issue:** langchain-ai#18804 @baskaryan @eyurtsev PTAL --------- Co-authored-by: ccurme <chester.curme@gmail.com>
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this issue
Mar 30, 2024
…hain-ai#19395) - **Issue:** langchain-ai#18804 - @eyurtsev @ccurme PTAL --------- Co-authored-by: Bagatur <baskaryan@gmail.com> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this issue
Mar 30, 2024
langchain-ai#19515) **Description:** Docstring for method with_listerners() of class Runnable **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this issue
Mar 30, 2024
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this issue
Mar 30, 2024
…thod (docs only) (langchain-ai#19192) - **Description:** Add in code documentation to core Runnable with_retry method (docs only) - **Issue:** langchain-ai#18804 @baskaryan @eyurtsev PTAL --------- Co-authored-by: ccurme <chester.curme@gmail.com>
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this issue
Mar 30, 2024
…hain-ai#19395) - **Issue:** langchain-ai#18804 - @eyurtsev @ccurme PTAL --------- Co-authored-by: Bagatur <baskaryan@gmail.com> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this issue
Mar 30, 2024
langchain-ai#19515) **Description:** Docstring for method with_listerners() of class Runnable **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this issue
Mar 30, 2024
marlenezw
pushed a commit
to marlenezw/langchain
that referenced
this issue
Apr 2, 2024
…igurable_alternatives (langchain-ai#19724) **Description:** Update to the docstring for class RunnableSerializable, method configurable_alternatives **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
marlenezw
pushed a commit
to marlenezw/langchain
that referenced
this issue
Apr 2, 2024
…figurable_fields (langchain-ai#19722) **Description:** Update to the docstring for class RunnableSerializable, method configurable_fields **Issue:** [Add in code documentation to core Runnable methods langchain-ai#18804](langchain-ai#18804) **Dependencies:** None --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
Je-Cp
pushed a commit
to Je-Cp/jcp-langchain
that referenced
this issue
Apr 2, 2024
…igurable_alternatives (#19724) **Description:** Update to the docstring for class RunnableSerializable, method configurable_alternatives **Issue:** [Add in code documentation to core Runnable methods #18804](langchain-ai/langchain#18804) **Dependencies:** None --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
Je-Cp
pushed a commit
to Je-Cp/jcp-langchain
that referenced
this issue
Apr 2, 2024
…figurable_fields (#19722) **Description:** Update to the docstring for class RunnableSerializable, method configurable_fields **Issue:** [Add in code documentation to core Runnable methods #18804](langchain-ai/langchain#18804) **Dependencies:** None --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
hinthornw
pushed a commit
that referenced
this issue
Apr 26, 2024
…thod (docs only) (#19192) - **Description:** Add in code documentation to core Runnable with_retry method (docs only) - **Issue:** #18804 @baskaryan @eyurtsev PTAL --------- Co-authored-by: ccurme <chester.curme@gmail.com>
hinthornw
pushed a commit
that referenced
this issue
Apr 26, 2024
hinthornw
pushed a commit
that referenced
this issue
Apr 26, 2024
…ly) (#19517) - **Issue:** #18804 - @baskaryan, @eyurtsev
hinthornw
pushed a commit
that referenced
this issue
Apr 26, 2024
…igurable_alternatives (#19724) **Description:** Update to the docstring for class RunnableSerializable, method configurable_alternatives **Issue:** [Add in code documentation to core Runnable methods #18804](#18804) **Dependencies:** None --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
good first issue
Good for newcomers
help wanted
Good issue for contributors
Ɑ: lcel
Related to LangChain Expression Language (LCEL)
Ɑ: Runnables
Related to Runnables
Privileged issue
Issue Content
Hi all!
Core Runnable methods are not documented well enough yet. It would be great to have each of the method include a self-contained usage example that folks can use as a reference.
Documenting these methods well will have a fairly high value impact by making is easier for LangChain users to use core LangChain primitives.
Runnable (
langchain/libs/core/langchain_core/runnables/base.py
Line 103 in bc6249c
RunnableSerializable (
langchain/libs/core/langchain_core/runnables/base.py
Line 1664 in bc6249c
Acceptance criteria
Please document only on method per PR to make it easy to review and get PRs merged quickly!
The text was updated successfully, but these errors were encountered: