Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: Patch XML vulnerability in XMLOutputParser (CVE-2024-1455) #19653

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Mar 27, 2024

Patch potential XML vulnerability CVE-2024-1455

This patches a potential XML vulnerability in the XMLOutputParser in langchain-core. The vulnerability in some situations could lead to a denial of service attack.

At risk are users that:

  1. Running older distributions of python that have older version of libexpat
  2. Are using XMLOutputParser with an agent
  3. Accept inputs from untrusted sources with this agent (e.g., endpoint on the web that allows an untrusted user to interact wiith the parser)

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 2:18pm

@eyurtsev eyurtsev marked this pull request as ready for review March 27, 2024 14:41
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 27, 2024
@dosubot dosubot bot added Ɑ: parsing Related to output parser module 🤖:security Related to security issues, CVEs labels Mar 27, 2024
@eyurtsev eyurtsev changed the title core[patch]: Patch XML vulnurability core[patch]: Patch XML vulnurability (CVE-2024-1455) Mar 27, 2024
@eyurtsev eyurtsev changed the title core[patch]: Patch XML vulnurability (CVE-2024-1455) core[patch]: Patch XML vulnerability (CVE-2024-1455) Mar 27, 2024
@eyurtsev eyurtsev changed the title core[patch]: Patch XML vulnerability (CVE-2024-1455) core[patch]: Patch XML vulnerability in XMLOutputParser (CVE-2024-1455) Mar 27, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 27, 2024
@eyurtsev eyurtsev merged commit e8339b1 into master Mar 27, 2024
95 checks passed
@eyurtsev eyurtsev deleted the eugene/xml_fix_2 branch March 27, 2024 16:41
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
… (langchain-ai#19653)

Patch potential XML vulnerability CVE-2024-1455

This patches a potential XML vulnerability in the XMLOutputParser in
langchain-core. The vulnerability in some situations could lead to a
denial of service attack.

At risk are users that:

1) Running older distributions of python that have older version of
libexpat
2) Are using XMLOutputParser with an agent
3) Accept inputs from untrusted sources with this agent (e.g., endpoint
on the web that allows an untrusted user to interact wiith the parser)
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
… (#19653)

Patch potential XML vulnerability CVE-2024-1455

This patches a potential XML vulnerability in the XMLOutputParser in
langchain-core. The vulnerability in some situations could lead to a
denial of service attack.

At risk are users that:

1) Running older distributions of python that have older version of
libexpat
2) Are using XMLOutputParser with an agent
3) Accept inputs from untrusted sources with this agent (e.g., endpoint
on the web that allows an untrusted user to interact wiith the parser)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13 security lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: parsing Related to output parser module 🤖:security Related to security issues, CVEs size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants