Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langchain[patch]: chat histories to handle optional community dependence #21194

Merged
merged 1 commit into from
May 2, 2024
Merged

langchain[patch]: chat histories to handle optional community dependence #21194

merged 1 commit into from
May 2, 2024

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented May 2, 2024 •
edited

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 2, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 2:23pm

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Ɑ: memory Related to memory module 🔌: astradb Primarily related to AstraDB integrations 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations 🔌: mongo Primarily related to Mongo integrations 🔌: neo4j Primarily related to Neo4j integrations 🔌: postgres Related to postgres integrations 🔌: redis Primarily related to Redis integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels May 2, 2024
@eyurtsev eyurtsev merged commit b5c3a04 into master May 2, 2024
42 checks passed
@eyurtsev eyurtsev deleted the eugene/migrate_chat_message_histories branch May 2, 2024 14:36
ccurme
ccurme approved these changes May 2, 2024
View reviewed changes
libs/langchain/langchain/memory/chat_message_histories/in_memory.py
from langchain._api import create_importer

if TYPE_CHECKING:
from langchain_community.chat_message_histories.in_memory import ChatMessageHistory
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do in another PR, but langchain_community just imports this from core, so it may make sense to do the same here?

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 2, 2024
@eyurtsev
Copy link
Collaborator Author

eyurtsev commented May 2, 2024

#21080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
🔌: astradb Primarily related to AstraDB integrations 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: memory Related to memory module 🔌: mongo Primarily related to Mongo integrations 🔌: neo4j Primarily related to Neo4j integrations 🔌: postgres Related to postgres integrations 🔌: redis Primarily related to Redis integrations size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eyurtsev @ccurme