JsonOutputFunctionParser: Fix mutation in place bug #8758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
🤖:bug
baskaryan
reviewed
Aug 4, 2023
| @@ -25,8 +25,8 @@ def parse_result(self, result: List[Generation]) -> Any: | |||
| ) | |||
| message = generation.message | |||
| try: | |||
| func_call = message.additional_kwargs["function_call"] | |||
| except ValueError as exc: | |||
| func_call = message.additional_kwargs["function_call"].copy() | |||
There was a problem hiding this comment.
should this be deep copied to be safe?
There was a problem hiding this comment.
Either works i favor shallow copies to keep things light weight though I think it hardly matters in this case as it's a tiny dict so deep copy works
baskaryan
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mutation in place in the JsonOutputFunctionParser. This causes issues
when trying to re-use the original AI message.