Extend DynamoDBChatMessageHistory to support composite keys #9896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
dosubot
bot
added
Ɑ: memory
baskaryan
reviewed
Aug 29, 2023
| @@ -28,10 +27,21 @@ class DynamoDBChatMessageHistory(BaseChatMessageHistory): | |||
| is optional and useful for test purposes, like using Localstack. | |||
| If you plan to use AWS cloud service, you normally don't have to | |||
| worry about setting the endpoint_url. | |||
| primary_key_name: name of the primary key of the DynamoDB table. This argument | |||
There was a problem hiding this comment.
can we specify that only one of primary_key_name or key should be passed in
hwchase17
approved these changes
Sep 3, 2023
Nantero1
reviewed
Sep 6, 2023
| @@ -84,6 +93,6 @@ def clear(self) -> None: | |||
| from botocore.exceptions import ClientError | |||
|
|
|||
| try: | |||
| self.table.delete_item(Key={"SessionId": self.session_id}) | |||
| self.table.delete_item(self.key) | |||
There was a problem hiding this comment.
TypeError: delete_item() only accepts keyword arguments.
IMHO this should be self.table.delete_item(Key=self.key)
@joshualwhite
3 tasks
baskaryan
pushed a commit
that referenced
this pull request
Sep 11, 2023
) **Description**: Fixed a bug introduced in version 0.0.281 in `DynamoDBChatMessageHistory` where `self.table.delete_item(self.key)` produced a TypeError: `TypeError: delete_item() only accepts keyword arguments`. Updated the method call to `self.table.delete_item(Key=self.key)` to resolve this issue. Please see also [the official AWS documentation](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb/table/delete_item.html#) on this **delete_item** method - only `**kwargs` are accepted. See also the PR, which introduced this bug: #9896 (comment) Please merge this, I rely on this delete dynamodb item functionality (because of GDPR considerations). **Dependencies**: None **Tag maintainer**: @hwchase17 @joshualwhite **Twitter handle**: [@BenjaminLinnik](https://twitter.com/BenjaminLinnik) Co-authored-by: Benjamin Linnik <Benjamin@Linnik-IT.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS DynamoDB Key docs