Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete/upsert support in FAISS #2427

Closed
jacoblee93 opened this issue Aug 28, 2023 · 3 comments · Fixed by #2924
Closed

Delete/upsert support in FAISS #2427

jacoblee93 opened this issue Aug 28, 2023 · 3 comments · Fixed by #2924
Assignees
@ewfian
Labels
auto:improvement Medium size change to existing code to handle new use-cases

Comments

@jacoblee93
Copy link
Collaborator

We've had a request for better delete/upsert support for the FAISS store - @ewfian would you be able to tackle adding it to the underlying package?

https://twitter.com/vsrisaijyothi/status/1696054437348069807?s=20
@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Aug 28, 2023
@ewfian
Copy link
Contributor

ewfian commented Aug 29, 2023

Confirmed that there is a delete method in the Python implementation, in order to maintain consistency, will implementing remove_ids on faiss-node side to support the delete

@ewfian ewfian mentioned this issue Aug 29, 2023
Closed
@jacoblee93
Copy link
Collaborator Author

Much appreciated!

@vkkon
Copy link

vkkon commented Sep 21, 2023 •
edited
Loading

How can I delete or update a document from the HNSWLib/FIASS index in Javascript? Much appreciated. Thanks.
@ewfian , @jacoblee93

@ewfian ewfian mentioned this issue Oct 15, 2023
Merged
jacoblee93 added a commit to ewfian/langchainjs that referenced this issue Oct 18, 2023
@jacoblee93
Merge branch 'main' of https://github.com/hwchase17/langchainjs into …
a6c4b81 
…fix/langchain-ai#2427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewfian ewfian

Labels
auto:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add delete for faiss ewfian/langchainjs
3 participants
@jacoblee93 @ewfian @vkkon