-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use official pinecone npm package #112
Conversation
Thanks @rschwabco 🎉 I'll get the new version in and update my pr accordingly. 🙇 |
I see 0.0.8 is available and just synced up with it. |
Have fixed the build too. |
Can you please take a look at this pull request and let me know what you think @hwchase17 ? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! dont mind the breaking changes that much given the earliness of the package
* Use official pinecone npm package (#112) * use official pinecone npm package * update doc * fix types for addVectors * sync up with 0.0.8 * UpsertResponse is not used * fix formatting for docs and examples * cr --------- Co-authored-by: Fraser Xu <xvfeng123@gmail.com>
… type safe (#127) * Pregel/Graph: Make channel creation explicit, make Pregel constructor type safe - still need to migrate StateGraph * Make type args const * Add stricter typings for graph/stategraph/messagegraph constructors (#128) * Add stricter typings for graph/stategraph/messagegraph constructors Inspired by #112 * Fix tests * Fix remaining types
#104
I was able to replace the pinecone client with official one easily without much change. Tested to index and search both works fine.
index
query
TODO: