Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[patch]: fix: #4997 zhipu chat model response typeError #5212

Merged
merged 1 commit into from
May 1, 2024
Merged

community[patch]: fix: #4997 zhipu chat model response typeError #5212

merged 1 commit into from
May 1, 2024

Conversation

jeasonnow
Copy link
Contributor

Fixes #4997

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 25, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2024 3:43am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 27, 2024 3:43am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Apr 25, 2024
@jacoblee93 jacoblee93 changed the title fix: #4997 zhipu chat model response typeError community[patch]: fix: #4997 zhipu chat model response typeError Apr 26, 2024
@jacoblee93 jacoblee93 added the close PRs that need one or two touch-ups to be ready label Apr 26, 2024
bracesproul
bracesproul approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for doing this!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Apr 30, 2024
@bracesproul bracesproul merged commit 1329a61 into langchain-ai:main May 1, 2024
17 checks passed
@jeasonnow jeasonnow deleted the fix/zhipu_type_error branch May 2, 2024 09:40
@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Closed
This was referenced Jun 11, 2024
Merged
Merged
@Avish24x Avish24x mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 left review comments

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature close PRs that need one or two touch-ups to be ready lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when invoke ZhipuAI chatmodel with invalid api key
3 participants
@jeasonnow @jacoblee93 @bracesproul