Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unclear S3Loader error message #5261

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix unclear S3Loader error message #5261

merged 2 commits into from
Apr 30, 2024

Conversation

Fiyin-Anne
Copy link
Contributor

@Fiyin-Anne Fiyin-Anne commented Apr 30, 2024 •
edited
Loading

Fixes #5253

The S3Loader return an unclear error message when trying to load an S3 object without a file type. This PR fixes that.

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:50pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 30, 2024 6:50pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Apr 30, 2024
bracesproul
bracesproul approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is a good update to have! Thanks for pushing this

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Apr 30, 2024
@bracesproul bracesproul merged commit ba8decf into langchain-ai:main Apr 30, 2024
17 checks passed
@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Closed
This was referenced Jun 11, 2024
Merged
Merged
@Avish24x Avish24x mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear Error Message "Failed to load file" From S3Loader.load()
2 participants
@Fiyin-Anne @bracesproul