community[patch]: fix Azure AI search delete and improve documentation #5272
Conversation
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
auto:bug
| const searchType = | ||
| this.options.type ?? AzureAISearchQueryType.SimilarityHybrid; |
There was a problem hiding this comment.
What's the reason for this change? Technically this is "breaking" to users in the sense that the functionality will be different.
There was a problem hiding this comment.
Hybrid search is the default retreival mode for other vector stores that support it. We'd like to align to that pattern as hybrid proves better retrevial quality vs pure vector search.
There was a problem hiding this comment.
We had a discussion regarding which search mode would bring the best relevance in most scenarios as a default value, and concluded that hybrid search should be the best for most use cases.
This is technically breaking, but people relying on defaults should get slightly improved relevance without any other impact on their code.
bracesproul
added
question
docs/core_docs/docs/integrations/vectorstores/azure_aisearch.mdx
Outdated
Show resolved
Hide resolved
docs/core_docs/docs/integrations/vectorstores/azure_aisearch.mdx
Outdated
Show resolved
Hide resolved
docs/core_docs/docs/integrations/vectorstores/azure_aisearch.mdx
Outdated
Show resolved
Hide resolved
docs/core_docs/docs/integrations/vectorstores/azure_aisearch.mdx
Outdated
Show resolved
Hide resolved
| const searchType = | ||
| this.options.type ?? AzureAISearchQueryType.SimilarityHybrid; |
There was a problem hiding this comment.
Hybrid search is the default retreival mode for other vector stores that support it. We'd like to align to that pattern as hybrid proves better retrevial quality vs pure vector search.
|
@bracesproul We've answered your comment, is there anything else you need from our side? |
Nope, lgtm and will get a release asap! |
bracesproul
added
lgtm
This PRs includes the following changes:
await initPromisewhen doing a delete with filter, causing race conditions