community[patch]: feat: add headers param to cheerio loader #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -92,11 +99,13 @@ export class CheerioWebBaseLoader | |||
| caller: AsyncCaller, | |||
There was a problem hiding this comment.
Hey there! I noticed that this code change introduces a new HTTP request using the fetch function with the addition of the headers parameter. I've flagged this for your review to ensure it aligns with the project's requirements. Let me know if you have any questions!
versole
changed the title
bracesproul
reviewed
Jun 20, 2024
Comment on lines
126
to
127
| this.textDecoder, | ||
| this.headers |
There was a problem hiding this comment.
This is passing headers via the options field.
Comment on lines
102
to
103
| options?: CheerioOptions, | ||
| headers?: Headers |
There was a problem hiding this comment.
Can we combine these? Something like this:
static async _scrape(
...other args...
options?: CheerioOptions & { headers?: Headers },
) {
const { headers, ...cheerioOptions } = options ?? {};
...existing code
}
jacoblee93
changed the title
jacoblee93
changed the title
bracesproul
approved these changes
Jun 20, 2024
bracesproul
reviewed
Jun 20, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request: Add a 'fetch headers' parameter to the Cheerio loader to accommodate different results based on the user-agent used.