Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[minor]: Support configurable index creation for Milvus #5821

Merged
merged 4 commits into from
Jun 20, 2024
Merged

community[minor]: Support configurable index creation for Milvus #5821

merged 4 commits into from
Jun 20, 2024

Conversation

yokingma
Copy link
Contributor

Summary

  • Add configurable parameters for index creation, So we can configure the index using index_type and metric_type.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 20, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 5:26pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 20, 2024 5:26pm

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Jun 20, 2024
bracesproul
bracesproul approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one nit around exporting types

libs/langchain-community/src/vectorstores/milvus.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jun 20, 2024
@bracesproul bracesproul changed the title feat: Supports configurable index creation for Milvus. community[minor]: Support configurable index creation for Milvus Jun 20, 2024
@bracesproul bracesproul merged commit 84163bc into langchain-ai:main Jun 20, 2024
33 checks passed
@lkolapp lkolapp mentioned this pull request Jul 13, 2024
Open
@gmickel gmickel mentioned this pull request Jul 13, 2024
Open
@steve-hb steve-hb mentioned this pull request Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yokingma @bracesproul @xqijia