-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anthropic[patch]: ensure content exists when parsing tool tokens #6183
Merged
bracesproul
merged 3 commits into
langchain-ai:main
from
snlamm:anthropic-non-text-tokens-parse
Jul 23, 2024
Merged
anthropic[patch]: ensure content exists when parsing tool tokens #6183
bracesproul
merged 3 commits into
langchain-ai:main
from
snlamm:anthropic-non-text-tokens-parse
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Jul 23, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc @bracesproul |
dosubot
bot
added
the
auto:bug
Related to a bug, vulnerability, unexpected error with an existing feature
label
Jul 23, 2024
5 tasks
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Jul 23, 2024
bracesproul
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing up this fix. I pushed a commit adding a test as well.
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6045
When anthropic extracts tokens during tool use, it's throwing an error on the
message_start
event, as it results in a chunk with an empty content array, but the current token parsing assumes that a single content item always exists. This PR fixes the issue.The current error thrown: