use the here package for managing file paths #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikriverson
commented
May 5, 2020
|
yes, seems reasonable to me to delete that.
…On Tue, May 5, 2020 at 8:59 AM Erik Iverson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In reports/hierarchicalrandomeffect_cache/html/__packages
<#155 (comment)>:
> @@ -6,16 +6,15 @@ tidyr
ggplot2
Should this file be deleted from the git repository? It looks like other
*_cache/* files are ignored in .gitignore, and perhaps this one snuck in
on accident. It does seem to cause an issue as there are packages in the
list that may not have been installed on the local machine as they do not
appear in the package installer list. This leads to the building of the
random effects paper to fail.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#155 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI25F4GBGQ7TM4NA73NQATRQAZUXANCNFSM4MZWEM3Q>
.
|
mcfrank
approved these changes
May 5, 2020
There was a problem hiding this comment.
you know, I don't think I have seen here shine in this way before! we use it in my lab for our analyses but it has mostly struck me as overkill. this particular use case where we are sourcing things from different locations via script etc. etc. seems like a really powerful one though!
I didn't review in depth but everything looks pretty straightforward. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the here package for managing file paths for both the static-generated site and the Shiny applications.