Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (openai_constants.py): add a new file to define constant MODEL_NAMES for OpenAI models #1858

Merged
merged 2 commits into from
May 8, 2024

Conversation

ogabrielluiz
Copy link
Contributor

♻️ (ChatOpenAISpecs.py, OpenAIModel.py): refactor to use MODEL_NAMES constant from openai_constants.py for consistency and easier maintenance

…S for OpenAI models

♻️ (ChatOpenAISpecs.py, OpenAIModel.py): refactor to use MODEL_NAMES constant from openai_constants.py for consistency and easier maintenance
…esh_button' for better clarity and consistency
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:46am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request python Pull requests that update Python code labels May 8, 2024
@ogabrielluiz ogabrielluiz merged commit 28c2585 into dev May 8, 2024
8 checks passed
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request May 15, 2024
…S for OpenAI models (langflow-ai#1858)

* ✨ (openai_constants.py): add a new file to define constant MODEL_NAMES for OpenAI models
♻️ (ChatOpenAISpecs.py, OpenAIModel.py): refactor to use MODEL_NAMES constant from openai_constants.py for consistency and easier maintenance

* ✨ (IDGenerator.py): update key name from 'real_time_refresh' to 'refresh_button' for better clarity and consistency

(cherry picked from commit 28c2585)
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request May 15, 2024
…S for OpenAI models (langflow-ai#1858)

* ✨ (openai_constants.py): add a new file to define constant MODEL_NAMES for OpenAI models
♻️ (ChatOpenAISpecs.py, OpenAIModel.py): refactor to use MODEL_NAMES constant from openai_constants.py for consistency and easier maintenance

* ✨ (IDGenerator.py): update key name from 'real_time_refresh' to 'refresh_button' for better clarity and consistency

(cherry picked from commit 28c2585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant