"Fix allowExport prop in CodeTabsComponent and ApiModal" #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conditionally render ExportModal component based on the prop value feat(apiModal): pass allowExport prop to CodeTabsComponent in ApiModal view feat(types): add allowExport prop to codeTabsPropsType in components index file
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
allowExportprop was not properly implemented in theCodeTabsComponentandApiModalviews. This pull request fixes the issue by adding theallowExportprop to theCodeTabsComponentand passing it to theApiModalview. Additionally, theallowExportprop is now properly validated in thecodeTabsPropsTypetype definition. The changes ensure that the ExportModal component is conditionally rendered based on the value of theallowExportprop.Also fix validateSelection that were changing the selection