Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove pysrt dependency (GPL3.0) #1930

Merged
merged 3 commits into from
May 23, 2024

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented May 20, 2024

pysrt is GPL 3.0 licensed and this brings deploying and packaging issues as LangFlow is a MIT licensed project.

pysrt is only used when using langchain document loader for loading .srt files. (SRTLoader)
The point is that if you wish to use it, you should add this additionally dependency to your application but it shouldn't be imported by default

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 20, 2024
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 10:31am

@dosubot dosubot bot added the python Pull requests that update Python code label May 20, 2024
@ogabrielluiz ogabrielluiz merged commit e7a387c into langflow-ai:dev May 23, 2024
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants