Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated pydantic validator #1960

Merged
merged 1 commit into from
May 26, 2024
Merged

Update deprecated pydantic validator #1960

merged 1 commit into from
May 26, 2024

Conversation

chyok
Copy link
Contributor

@chyok chyok commented May 23, 2024

Hi,
This PR migrates the deprecated pydantic v1 syntax to the v2 version.

@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 3:18pm

@chyok chyok marked this pull request as draft May 23, 2024 16:18
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. python Pull requests that update Python code labels May 23, 2024
@chyok chyok marked this pull request as ready for review May 23, 2024 17:23
@dosubot dosubot bot added the enhancement New feature or request label May 23, 2024
ogabrielluiz
ogabrielluiz approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chyok

Thanks again for the help!

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 23, 2024
@chyok
Copy link
Contributor Author

chyok commented May 24, 2024

Hi, @ogabrielluiz
It looks like the failed unit tests are due to the environment variable OPENAI_KEY not being set, successful pipelines will have this set.
image

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels May 25, 2024
@ogabrielluiz ogabrielluiz merged commit 9f2a0d1 into langflow-ai:dev May 26, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chyok @ogabrielluiz