Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating to Vite #287

Merged
merged 3 commits into from
May 13, 2023
Merged

migrating to Vite #287

merged 3 commits into from
May 13, 2023

Conversation

gsaivinay
Copy link
Contributor

This PR implements #264

Changes done

  • Organized package.json for dev only dependencies.
  • Removed react-scripts and added Vite and its dependencies.
  • Refactored require with import in few places.

Changes to development process

  • Most of the development workflow is unchanged with this migration.
  • For any API call to backend, the path must be added in the vite.config.ts so that vite server can forward it to backend server via proxy. This can be standardized with naming conventions so that we can simply configure regular expressions and forget about it.

Testing

  • Build and test
  • Run dev servers and test

@gsaivinay
Copy link
Contributor Author

@ogabrielluiz - I created new PR from the same branch, as the previous one showing lot of commits and diff after rebase. Once the tests are done and there is enough confidence, we can merge.

@ogabrielluiz
Copy link
Contributor

I'll run the tests ASAP, probably today. I'm sure it will be work, though =) Thanks for the help @gsaivinay

@ogabrielluiz
Copy link
Contributor

LGTM

@ogabrielluiz ogabrielluiz merged commit 061743a into langflow-ai:dev May 13, 2023
@ogabrielluiz ogabrielluiz linked an issue May 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRA to Vite?
2 participants