fix: node.js sdk if request is a get data must not exist #4618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When making HTTP requests, the sendRequest method currently includes a body even for GET requests. According to HTTP standards, GET requests should not have a body. Including a body in GET requests can lead to unexpected behavior and compatibility issues with servers that strictly adhere to HTTP specifications.
I noticed this problem using gcloud as host of my platform.
Fixes # (issue)
#4617
Type of Change
I added a conditional check inside the sendRequest method. If the request method is GET, the request body is removed to ensure compliance with HTTP standards.
Please delete options that are not relevant.
How Has This Been Tested?
I updated the related test Send Requests.
There is a test that checked the content of a GET request.
Should be without data not with data:null
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes