Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node.js sdk if request is a get data must not exist #4618

Merged

Conversation

valerionarcisi
Copy link
Contributor

@valerionarcisi valerionarcisi commented May 23, 2024

Description

When making HTTP requests, the sendRequest method currently includes a body even for GET requests. According to HTTP standards, GET requests should not have a body. Including a body in GET requests can lead to unexpected behavior and compatibility issues with servers that strictly adhere to HTTP specifications.

I noticed this problem using gcloud as host of my platform.

Fixes # (issue)
#4617

Type of Change

I added a conditional check inside the sendRequest method. If the request method is GET, the request body is removed to ensure compliance with HTTP standards.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

I updated the related test Send Requests.
There is a test that checked the content of a GET request.
Should be without data not with data:null

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ javascript 🐞 bug Something isn't working labels May 23, 2024
@valerionarcisi valerionarcisi changed the title fix: sdk if request is a get data must not exist fix: node.js sdk if request is a get data must not exist May 23, 2024
@takatost takatost requested a review from crazywoola May 24, 2024 03:42
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 25, 2024
@crazywoola crazywoola merged commit af026c5 into langgenius:main May 27, 2024
7 checks passed
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants