Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local candidate priority assignment #103

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Conversation

thinkski
Copy link
Member

In multi-homed or dual-stack (i.e. both IPv4 and IPv6) configurations,
local candidates must use unique local preferences for the same
candidate type preference and component ID. Otherwise, the controlling
and controlled agent could pick different candidates.

This commit uses a simple interleaved down-counter, starting the
local preference at 65534 for IPv4 and 65535 for IPv6, decrementing
each by two per local candidate.

Fixes #102

In multi-homed or dual-stack (i.e. both IPv4 and IPv6) configurations,
local candidates must use unique local preferences for the same
candidate type preference and component ID. Otherwise, the controlling
and controlled agent could pick different candidates.

This commit uses a simple interleaved down-counter, starting the
local preference at 65534 for IPv4 and 65535 for IPv6, decrementing
each by two per local candidate.
@thinkski thinkski self-assigned this Aug 30, 2019
Copy link
Collaborator

@jwgcarlson jwgcarlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thinkski thinkski merged commit a3f7213 into master Aug 30, 2019
@thinkski thinkski deleted the fix-lcand-priority branch August 30, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race in candidate selection
2 participants