-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: GasLib parsing functions and implementation of pressure reducing valves #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring of modeling pipe flow directions
refactoring resistor direction data
Direction refactor
Refactoring of compressor directions
Codecov Report
@@ Coverage Diff @@
## direction_refactor #202 +/- ##
======================================================
+ Coverage 73.73% 75.16% +1.42%
======================================================
Files 34 35 +1
Lines 3449 3901 +452
======================================================
+ Hits 2543 2932 +389
- Misses 906 969 +63
Continue to review full report at Codecov.
|
rb004f
reviewed
Jul 1, 2020
kaarthiksundar
approved these changes
Jul 6, 2020
… minimum flows of zero.
…b integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first shot at implementing a GasLib parser. It also includes the implementation of pressure reducing valves, which appear as special resistors in the new
GasLib-4197
case. The parser enables the solution of all GasLib instances on the official website when using thegf
problem specification with theMISOCPGasModel
formulation. I haven't yet tested with other problem specifications or formulations. A review would be appreciated!