Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: GasLib parsing functions and implementation of pressure reducing valves #202

Merged
merged 64 commits into from
Aug 6, 2020

Conversation

tasseff
Copy link
Member

@tasseff tasseff commented Jun 30, 2020

This is a first shot at implementing a GasLib parser. It also includes the implementation of pressure reducing valves, which appear as special resistors in the new GasLib-4197 case. The parser enables the solution of all GasLib instances on the official website when using the gf problem specification with the MISOCPGasModel formulation. I haven't yet tested with other problem specifications or formulations. A review would be appreciated!

tasseff and others added 26 commits May 29, 2020 09:48
Refactoring of modeling pipe flow directions
refactoring resistor direction data
Refactoring of compressor directions
@tasseff tasseff requested a review from rb004f June 30, 2020 03:12
@tasseff tasseff changed the base branch from master to direction_refactor June 30, 2020 03:13
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #202 into direction_refactor will increase coverage by 1.42%.
The diff coverage is 77.25%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           direction_refactor     #202      +/-   ##
======================================================
+ Coverage               73.73%   75.16%   +1.42%     
======================================================
  Files                      34       35       +1     
  Lines                    3449     3901     +452     
======================================================
+ Hits                     2543     2932     +389     
- Misses                    906      969      +63     
Impacted Files Coverage Δ
src/GasModels.jl 25.00% <ø> (ø)
src/core/objective.jl 61.53% <ø> (ø)
src/form/lrdwp.jl 34.14% <0.00%> (-1.76%) ⬇️
src/form/lrwp.jl 43.22% <0.00%> (-0.57%) ⬇️
src/core/constraint_mi.jl 57.47% <37.50%> (-0.83%) ⬇️
src/core/constraint_template_mi.jl 64.33% <50.00%> (+0.21%) ⬆️
src/prob/ls.jl 73.17% <50.00%> (-2.51%) ⬇️
src/prob/ne.jl 68.96% <50.00%> (-1.41%) ⬇️
src/prob/nels.jl 67.24% <50.00%> (-1.28%) ⬇️
src/prob/ogf.jl 66.66% <66.66%> (-1.63%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f333f...d348dfc. Read the comment docs.

src/core/constraint.jl Outdated Show resolved Hide resolved
tasseff and others added 24 commits July 8, 2020 14:30
@rb004f rb004f merged commit f65817d into direction_refactor Aug 6, 2020
@kaarthiksundar kaarthiksundar deleted the gaslib-converter branch September 2, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants