Update Neo4j to 5.x #819
Merged
Update Neo4j to 5.x #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the neo4j container management code and driver version. The gdb code has also been updated to work with the new driver version, which made breaking changes to how transaction functions are handled. No changes have been made to the cypher queries yet, although they seemed to work for the cat-grep-tar workflow.
|
@jtronge Is this still WIP? Maybe we need to revisit our labels. |
|
I think this might be ready for more local testing now. Maybe we should change WIP so that it always runs CI actions? That's the only reason I left it off, so that I could run this PR through CI. I think we set it that way in the first place to avoid wasting CI time, but I'm not sure that's still a major problem. |
pagrubel
approved these changes
Apr 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should update BEE to use neo4j 5.x. See issue #817. I've updated the Python API and made a couple changes to how neo4j is launched.
This is still a WIP but I'm opening it now to see if the CI passes.