Allow removal of a workflow with any Archive status #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me! Approved. |
rstyd
approved these changes
May 14, 2024
|
I'd like to understand this a bit better in light of the work I'm doing concerning slurm, so putting the WIP label back on so we don't merge it yet. |
|
Gotcha thanks! |
|
Sorry this was not the PR I wanted to hold off on. So I removed the WIP lablel |
|
Oh okay in that case I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to remove a workflow with the new Archive/Failed status, it was not allowed because beeflow wasn't aware of this status and thought the workflow might be running. This PR now allows any workflow with a status containing Archive to be removed.