update submodules #124
Merged
update submodules #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for |
|
Ok I think everything should work now, modulo Philipp's I/O thing. Should we merge this now (when tests pass) or wait for that to get into Parthenon? |
|
Oops forgot to push my cmake fixes |
lroberts36
reviewed
Aug 18, 2022
|
Chicoma now works again. See parthenon-hpc-lab/parthenon#720 |
|
@lroberts36 are you happy with this? If so I think it's ready for merge. I think we should update to the new HDF5 format in a separate PR, as this one ended up being more than a few headaches, and I'd like those resolved with a PR/commit number before introducing more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
This PR updates us to the newest parthenon. I plan to use this to check against Philipp Grete's I/O fix. But it also brings us up to date with all of @lroberts36 sparse fixes, and moves some more things into "in-one," which maybe will help with performance.
One question to ask is if we wait to merge this in until Philipp's IO change is in main or just do two PRs.
I'm also working on updating singularity-eos so we can be up to date there. This requires a few minor changes to the build system. One annoying aspect is I found a build system bug in singularity-eos which I'm fixing at the moment.
scripts/bash/format.sh.