Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scattering #134

Merged
merged 27 commits into from
Oct 28, 2022
Merged

Add scattering #134

merged 27 commits into from
Oct 28, 2022

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Oct 25, 2022 •
edited
Loading

PR Summary

This PR adds support for the new (mean) scattering opacity calls in singularity-opac.

It also reorganizes the singularity opacity objects into a single class provided by phoebus/microphysics/opac_phoebus to the rest of phoebus.

This PR removes the scattering_fraction parameter.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by calling scripts/bash/format.sh.
  • Explain what you did.

Yurlungur
Yurlungur approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems reasonable to me.

src/radiation/cooling_function.cpp Show resolved Hide resolved
src/pgen/radiation_advection.cpp Show resolved Hide resolved
src/microphysics/opac_phoebus/opac_phoebus.cpp Outdated Show resolved Hide resolved
src/microphysics/opac_phoebus/opac_phoebus.hpp Outdated Show resolved Hide resolved
brryan
brryan commented Oct 26, 2022
View reviewed changes
scripts/python/phoedf.py Outdated Show resolved Hide resolved
@brryan
Copy link
Collaborator Author

brryan commented Oct 28, 2022

This passes the CI and the rad torus looks good right now so I'm merging

@brryan brryan merged commit 0a4da7c into main Oct 28, 2022
This was referenced Oct 28, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@lroberts36 lroberts36 Awaiting requested review from lroberts36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brryan @Yurlungur