Updating torus.cpp to run without radiation #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brryan
reviewed
Oct 31, 2022
| @@ -277,6 +251,28 @@ void ProblemGenerator(MeshBlock *pmb, ParameterInput *pin) { | |||
|
|
|||
| // Radiation | |||
| if (do_rad) { | |||
| StateDescriptor *opac = pmb->packages.Get("opacity").get(); | |||
There was a problem hiding this comment.
This won't work on GPU because you're trying to access host side variables (the Opacities object in Params) inside a compute kernel which can be on GPU. Instead, you have to pull out some Opacities object outside of the compute loop and let Kokkos capture that object by value.
There was a problem hiding this comment.
Good to know - thanks!
There was a problem hiding this comment.
👍 I've been tripped up by this a number of times, and it's something to watch out for especially since we still don't quite have the CI running on gpus.
|
Nice work getting this working, these are the same issues I noticed and fixed in #142, I recommend we merge that branch instead of this because my changes are a bit different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent updates, the non-radiative torus problem failed when trying to get opacities. I moved all radiation related calls into
if (do_rad) {...}and am now able to run bothtorus.pinandtorus_rad.pinwithout issue.I also added the
c2p_failure_force_fixup_both = falseflag to thetorus.pininputs to accommodate those recent changes.